mlx launch clean#3513
Merged
angeloskath merged 2 commits intoMay 11, 2026
Merged
Conversation
angeloskath
approved these changes
May 11, 2026
Member
angeloskath
left a comment
angeloskath
left a comment
There was a problem hiding this comment.
Awesome. You can now do
mlx.distributed_config --hosts h1,h2,h3,h4 --auto-setup --output hosts.json
and it will auto select everything.
Do you think we should remove the automatic insertion of python if a script is provided? Basically if foo.py exists locally and remotely then it will try to add args.python in front of it...
I basically think lines 544-548 may cause more harm than good.
Member
|
@nastya236 I 'll merge this, let me know if you think we should remove 544-548. |
Collaborator
Author
|
Agree these lines! I had a doubt (removed it first, then committed back :) Lets remove it, I think we should just always give executable full path for simplicity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mlx.launch. Alternatively we can swap it to--verify-scriptand verify only conditionally ?required=Truefor--over flag-- this could be not ideal, we might want to require explicit interconnect specification. Then we shouldrequired=Trueand drop default ?