Skip to content
This repository was archived by the owner on Apr 6, 2020. It is now read-only.

changing example to dropdown#130

Merged
joeyklee merged 2 commits into
developmentfrom
cvae-example-dropdown
Apr 29, 2019
Merged

changing example to dropdown#130
joeyklee merged 2 commits into
developmentfrom
cvae-example-dropdown

Conversation

@shiffman
Copy link
Copy Markdown
Member

→ Description 📝

Based on feedback from @joeyklee in #125, I'm adjusting the example to use a dropdown! I still couldn't get preload() to work with ml5js/ml5-library#360. @WenheLI can you check? With preload() I can move the createSelect() to setup().

→ Screenshots 🖼

Screen Shot 2019-04-27 at 9 44 30 AM

Screen Shot 2019-04-27 at 9 44 21 AM

@shiffman shiffman requested a review from joeyklee April 27, 2019 16:48
@WenheLI
Copy link
Copy Markdown
Member

WenheLI commented Apr 27, 2019

The CVAE does register into the preloadMethods, but p5 does not wait for it. It seems to be related with the two successive callback functions inside the constructor. I may need a more in-depth investigation of this problem.

Copy link
Copy Markdown
Contributor

@joeyklee joeyklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Nice one @shiffman. One thing I like about using the dropdown menu over the keyup and keydown is that people can also start to see how they might populate a dropdown selector. Nice!

@joeyklee
Copy link
Copy Markdown
Contributor

@shiffman @WenheLI - I'm going to merge this in for now. If/when preload() is sorted, we can add this in at that time. Thanks you two!

@joeyklee joeyklee merged commit d0c2b72 into development Apr 29, 2019
joeyklee added a commit that referenced this pull request May 24, 2019
* set ml5 reference to localhost

* Unet example webcam (#120)

* added uNet example

* rm video from model load

* updated UNET example to current UNET implementation

* set frameRate to 5

* Tinkering with segmentation example (#121)

I am not sure this is better. I do prefer calling `segment()` from `gotResult()` itself, but maybe creating a blank image to eliminate the `draw()` if statement isn't a good idea.

* Sentiment example (#118)

* added sentiment example

* move to p5js

* fixed unet sketch at segmentationImage (#122)

* add cvae example (#117)

* added new cvae example (#123)

* handle html elements in p5 and cleaned up functions (#124)

* simplify CVAE example (#125)

* simplfiying the sentiment example (#126)

* simplify unet example (#127)

* Update localhost reference and script (#129)

* added http://localhost:8080/ml5.js

* added all examples with correct http://localhost:8080/ml5.js

* changing example to dropdown (#130)

* changing example to dropdown

* comments

* Adds DCGAN example (#138)

* initial commit

* adds example of dcgan using small face model

* use named function for callback

* rm console.log

* updated className to label (#141)

* Feature extractor update to specify number of labels (#142)

* added additional label - show how to specify label nums

* adds object as input to .classificaiton()

* changed version ml5 reference to 0.3.0

* added p5 version 0.8.0
@joeyklee joeyklee deleted the cvae-example-dropdown branch June 27, 2019 14:23
joeyklee pushed a commit that referenced this pull request Nov 7, 2019
* changing example to dropdown

* comments
joeyklee added a commit that referenced this pull request Nov 7, 2019
* set ml5 reference to localhost

* Unet example webcam (#120)

* added uNet example

* rm video from model load

* updated UNET example to current UNET implementation

* set frameRate to 5

* Tinkering with segmentation example (#121)

I am not sure this is better. I do prefer calling `segment()` from `gotResult()` itself, but maybe creating a blank image to eliminate the `draw()` if statement isn't a good idea.

* Sentiment example (#118)

* added sentiment example

* move to p5js

* fixed unet sketch at segmentationImage (#122)

* add cvae example (#117)

* added new cvae example (#123)

* handle html elements in p5 and cleaned up functions (#124)

* simplify CVAE example (#125)

* simplfiying the sentiment example (#126)

* simplify unet example (#127)

* Update localhost reference and script (#129)

* added http://localhost:8080/ml5.js

* added all examples with correct http://localhost:8080/ml5.js

* changing example to dropdown (#130)

* changing example to dropdown

* comments

* Adds DCGAN example (#138)

* initial commit

* adds example of dcgan using small face model

* use named function for callback

* rm console.log

* updated className to label (#141)

* Feature extractor update to specify number of labels (#142)

* added additional label - show how to specify label nums

* adds object as input to .classificaiton()

* changed version ml5 reference to 0.3.0

* added p5 version 0.8.0
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants