Misha/await status change rework #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added chain-index polling interval and timeout - todo: config and tests
- tests added - config spec added - bugs fixed - todo: docs, refactoring, testnet tests
- docs - clenaup - testnet tested
mikekeke
commented
Jun 17, 2022
mikekeke
commented
Jun 17, 2022
| | start + n <= tip'.block -> pure () | ||
| _ -> go start | ||
| -- -- | Wait for n Blocks. | ||
| -- awaitNBlocks :: |
Collaborator
Author
There was a problem hiding this comment.
This can probably be removed
mikekeke
commented
Jun 17, 2022
| netId | ||
| socket | ||
| where | ||
| -- This parameter needed only for the Byron era. Since the Byron |
Collaborator
Author
There was a problem hiding this comment.
Found this explanation somewhere in latest node commits
mikekeke
commented
Jun 17, 2022
nazrhom
reviewed
Jun 17, 2022
nazrhom
reviewed
Jun 17, 2022
nazrhom
approved these changes
Jun 20, 2022
Collaborator
Author
|
For some reason it breaks Plutip's tests with |
mikekeke
force-pushed
the
misha/await-status-change-rework
branch
from
4134755 to
bcea30f
Compare
Collaborator
Author
The problem was not caused directly by this rework, but fix committed here as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce changes in
awaitTxStatusChangemaking it closer to what real PAB is doing - it waits until transaction status will change fromUnknownto anything else with some nuances:chain-indexto get transaction, if transaction not found status is considered to beUnknownand it will keep queryingUnknownand it will keep queryingchain-indexis configurable viaPABConfigPABConfig. Timeout required for the case, when transaction is (silently) discarded from node mempool. In this case transaction will never show up on chain and awaiting can loop forever. After timeout is reached, status from the last check will be returned, it can beUnknownas well, soawaitTxConfirmedwhich is implemented viaawaitTxStatusChangecan still loop forever. Upcoming node release will introduce queries to mempool inCardano.Api- maybe it could be a replacement for timeout.