-
Notifications
You must be signed in to change notification settings - Fork 8
scaffolding #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scaffolding #1
Conversation
aciceri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my head we should have a modules directory that contains a default.nix file (which is a flake.parts module) and other subdirectories. Each subdirectory contains at least a default.nix (which is a NixOS module) which imports interface.nix and implementation.nixand potentially other files (if the module need other files, also non Nix files). It would be nice if the flake.parts module was able to automatically expose as flake.nixosModules by scanning the modules directory.
For tests I was imagining exactly the same structure but with the top level folder named tests.
Signed-off-by: Alexander V. Nikolaev <avn@avnik.info>
| mainnet = 0; | ||
| private = 42; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| mainnet = 0; | |
| private = 42; | |
| mainnet = 764824073; | |
| preprod = 1; | |
| preview = 2; | |
| sanchonet = 4; |
Not sure about mainnet, usually you never use it because you pass --mainnet or --testnet-magic <n>.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I would rename the option to protocolMagic for consistency different networks genesis files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree about protocolMagic, because it a high-level option regarding decide network to use. I extract values from iohk-lib.nix, so it can differ from protocol magic numbers. Anyway, we can rename it later,if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where have you extracted those values exactly?
I got them from https://github.com/input-output-hk/cardano-configurations/blob/master/network/mainnet/genesis/byron.json (you can change mainnet to other network names), look for the protocolMagic key in the JSONs.
For now let's ignore this, I'm merging it.
avnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like I fixed everything
5e1e782 to
3802540
Compare
3802540 to
fd4fa6d
Compare
|
@avnik Did some dumb polishing before merging, nothing worth to be discussed, just FYY:
@zmrocze now this repo has a skeleton if you to take a look. Anyway #2 and #3 (which should be implemented in mlabs-haskell/devops) still have the priority. |
|
@zmrocze since perhaps the CI thing it's a big confusing. Currently this repo has a working CI but it's still using the MLabs agent. Instead it has to use an ad hoc agent that pushes to an ad hoc cache. |
No description provided.