precommit hooks #25
Merged
precommit hooks #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avnik
force-pushed
the
avnik/precommit-hooks
branch
from
b438ba1 to
6be1548
Compare
Contributor
|
Assigning to Milestone 2 as Milestone 1 was accepted without this. |
brainrake
force-pushed
the
avnik/precommit-hooks
branch
from
6be1548 to
dd93269
Compare
Contributor
|
I have rebased, reviewed and tested this. It did need |
Contributor
|
i think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototyping solution for #22
I not satisfied it much, because injecting into devshell is very hacky (or doesn't work with direnv, and require explicit
nix developat least once).Also still doubt, if we need it or not.
Open list of questions:
deadnixfrom treefmt to pre-commit?nix flake checkinstead of "just treefmt"