Skip to content

Conversation

@brainrake
Copy link
Contributor

@brainrake brainrake commented Mar 21, 2024

fixes #30 #31 #32

  • cardano-node 8.8.* and 8.9.* do not build so we're stuck with 8.7.3
  • work around cardano-node socket permissions issue: poll and chmod
  • work around cardano-node configuration json sharing issue: set from cardano-configurations for all services (found specific version for cardano-node 8.7.3)
  • add ogmios binary release 6.1.0 6.2.0 because it fails to build with haskell.nix and 6.0.3 is too old
  • add ogmios module from ogmios-nixos
  • update ogmios module to work with newer ogmios
  • update ogmios module to work with cardano.nix cardano-node
  • avoid segfaults, lock down ogmios systemd security
  • update module field documentation
  • update vmTests (formerly nixosTests) to automatically handle checks, effects, and add apps to run tests
  • update vmTests to expose check and effect derivations
  • fix run-vm-test argument quotation and shellcheck errors
  • add vm test to check ogmios sync progress
  • update readme, detail how to run integration test showing cardano-node and ogmios works

@brainrake brainrake force-pushed the marton/ogmios-module branch 4 times, most recently from 54767fd to 1332932 Compare March 21, 2024 12:58
@brainrake brainrake force-pushed the marton/ogmios-module branch 6 times, most recently from c5414b2 to fc335fa Compare March 23, 2024 19:27
@brainrake brainrake marked this pull request as ready for review March 23, 2024 19:27
@brainrake brainrake requested a review from aciceri March 23, 2024 19:27
@brainrake brainrake added this to the 2. Processing modules pt. 1 milestone Mar 23, 2024
@brainrake brainrake force-pushed the marton/ogmios-module branch 2 times, most recently from c1cae70 to 838fb65 Compare March 23, 2024 19:32
@brainrake brainrake mentioned this pull request Mar 23, 2024
@brainrake brainrake force-pushed the marton/ogmios-module branch from 838fb65 to eeb27ea Compare March 24, 2024 01:26
@brainrake brainrake force-pushed the marton/ogmios-module branch from eeb27ea to 8881ab1 Compare March 24, 2024 01:34
@brainrake brainrake changed the title Ogmios package and module Ogmios package, module and test Mar 24, 2024
@brainrake brainrake self-assigned this Mar 26, 2024
avnik
avnik previously requested changes Mar 26, 2024
Copy link
Contributor

@avnik avnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally all comments are non-blocking, if you argument -- I can withdraw my comment, and approve during today meeting.
General LGTM

@brainrake brainrake force-pushed the marton/ogmios-module branch 2 times, most recently from c06ca5d to f587761 Compare March 26, 2024 17:18
@brainrake brainrake force-pushed the marton/ogmios-module branch from f587761 to b00ae15 Compare March 26, 2024 17:21
@aciceri
Copy link
Member

aciceri commented Mar 26, 2024

Oh also the documentation is not generated for modules in modules/services

brainrake and others added 5 commits March 26, 2024 21:52
Co-authored-by: Andrea Ciceri <andrea.ciceri@autistici.org>
Co-authored-by: Andrea Ciceri <andrea.ciceri@autistici.org>
@brainrake
Copy link
Contributor Author

Added issue for documentation since I could not fix it quickly.
#54

@brainrake
Copy link
Contributor Author

Resolved all issues discussed above.

@brainrake
Copy link
Contributor Author

ogmios 6.2.0 just came out

@brainrake brainrake force-pushed the marton/ogmios-module branch from 9b5fcdb to 60c0368 Compare March 28, 2024 19:31
@aciceri aciceri dismissed avnik’s stale review April 2, 2024 09:50

Everything is addressed now

@aciceri aciceri merged commit fb670cb into main Apr 2, 2024
@aciceri aciceri deleted the marton/ogmios-module branch April 2, 2024 09:51
@aciceri aciceri restored the marton/ogmios-module branch April 2, 2024 09:51
@aciceri aciceri deleted the marton/ogmios-module branch April 2, 2024 09:54
Copy link
Contributor

@zmrocze zmrocze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NixOS package for ogmios

5 participants