Skip to content

refactor #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2024
Merged

refactor #49

merged 2 commits into from
Apr 3, 2024

Conversation

@brainrake
Copy link
Contributor

@brainrake brainrake commented Mar 23, 2024 •
edited
Loading

merge after #46

  • fixes refactor #48
  • renames
    cardanoNix -> cardano
    cardanoNix.globals -> cardano
    cardanoNix.cardano-cli -> cardano.cli
    cardanoNix.cardano-node -> cardano.node
  • update .gitignore
  • add example to readme
  • cleanup
  • rm lib.nix since we don't use it
  • fix main branch name
  • add cardano.enable which starts everything

@brainrake brainrake force-pushed the marton/refactor branch 2 times, most recently from 1350bd6 to 4f95ea4 Compare March 24, 2024 01:46
@brainrake brainrake self-assigned this Mar 24, 2024
@brainrake brainrake added this to the 3. Processing modules pt. 2 milestone Mar 24, 2024
@brainrake brainrake force-pushed the marton/refactor branch 3 times, most recently from 629304d to ef39be0 Compare March 28, 2024 19:57
@brainrake brainrake mentioned this pull request Apr 1, 2024
Merged
@brainrake brainrake marked this pull request as ready for review April 3, 2024 15:13
@brainrake brainrake requested a review from aciceri April 3, 2024 15:13
aciceri
aciceri approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@aciceri aciceri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Also agree with the renaming choices

tests/cardano-cli.nix
Comment on lines -5 to -8
virtualisation = {
cores = 2;
memorySize = 1024;
};
Copy link
Member

@aciceri aciceri Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the default?

Copy link
Contributor Author

@brainrake brainrake Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cores = 1, memorySize = 1024
https://github.com/NixOS/nixpkgs/blob/75a18a64ed1f53647a429142d18ce54c8432cfa3/nixos/modules/virtualisation/qemu-vm.nix#L453

@brainrake brainrake merged commit 3ee4657 into main Apr 3, 2024
@brainrake brainrake deleted the marton/refactor branch April 3, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aciceri aciceri aciceri approved these changes

Assignees

@brainrake brainrake

Labels

None yet

Projects

None yet

Milestone

2. Processing modules pt. 1

Development

Successfully merging this pull request may close these issues.

refactor

3 participants

@brainrake @aciceri