Typescript testsuite #177
Merged
Typescript testsuite #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredponn
force-pushed
the
jared/typescript-testsuite
branch
2 times, most recently
from
2490cd4 to
d7563ad
Compare
jaredponn
force-pushed
the
jared/typescript-codegen
branch
from
1945253 to
527b40c
Compare
jaredponn
force-pushed
the
jared/typescript-testsuite
branch
from
d7563ad to
b1ad866
Compare
jaredponn
force-pushed
the
jared/typescript-codegen
branch
from
527b40c to
bdd1b2b
Compare
jaredponn
force-pushed
the
jared/typescript-testsuite
branch
from
b1ad866 to
9c0e365
Compare
jaredponn
force-pushed
the
jared/typescript-testsuite
branch
from
cacac73 to
7b41826
Compare
jaredponn
force-pushed
the
jared/typescript-testsuite
branch
from
3369bc6 to
e917194
Compare
jaredponn
force-pushed
the
jared/typescript-testsuite
branch
from
6b6e203 to
343a1a9
Compare
jaredponn
force-pushed
the
jared/typescript-testsuite
branch
2 times, most recently
from
04adcb7 to
2393fe9
Compare
jaredponn
force-pushed
the
jared/typescript-testsuite
branch
from
2393fe9 to
5986a31
Compare
jaredponn
commented
Jan 29, 2024
lambda-buffers-codegen/src/LambdaBuffers/Codegen/Typescript/Print/LamVal.hs
Show resolved
Hide resolved
bladyjoker
approved these changes
Jan 31, 2024
Contributor
bladyjoker
left a comment
bladyjoker
left a comment
There was a problem hiding this comment.
Haha awesome stuff! This is pretty good, left a few minor comments, but otherwise 💚
lambda-buffers-codegen/src/LambdaBuffers/Codegen/Typescript/Print/LamVal.hs
Show resolved
Hide resolved
jaredponn
force-pushed
the
jared/typescript-testsuite
branch
4 times, most recently
from
3e5b734 to
788a102
Compare
jaredponn
force-pushed
the
jared/typescript-testsuite
branch
from
788a102 to
bd178bb
Compare
bladyjoker
approved these changes
Feb 1, 2024
Contributor
bladyjoker
left a comment
bladyjoker
left a comment
There was a problem hiding this comment.
If you have the will power to fix lbfXyzTypescript as I describe please go ahead, but regardless this looks good and feel free to merge when ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was done;