Skip to content

added cors to fast api #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 20, 2023
Merged

added cors to fast api #757

merged 1 commit into from
Aug 20, 2023

Conversation

@demattosanthony
Copy link
Contributor

@demattosanthony demattosanthony commented Aug 15, 2023

Currently getting this error when trying to call the rest api from the browser:

Access to XMLHttpRequest at 'http://127.0.0.1:8000/v1/chat/completions' from origin 'http://localhost:4000' has been blocked by CORS policy: Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource.

@tqchen tqchen requested a review from sudeepag August 15, 2023 01:11
@sudeepag sudeepag merged commit d4ca67e into mlc-ai:main Aug 20, 2023
jimscard added a commit to jimscard/mlc-llm that referenced this pull request Sep 15, 2023
@jimscard
Merge branch 'main' of https://github.com/jimscard/mlc-llm
f3afec2 
* 'main' of https://github.com/jimscard/mlc-llm:
  [Doc] Minor update to `Build Android Package from Source` section (mlc-ai#785)
  added cors to fast api (mlc-ai#757)
  Update Llama2 cached sin/cos to use max_sequence_length (mlc-ai#780)
  Update gpu.rst to add sudo apt update before first install (mlc-ai#784)
  [Doc] Update doc for prebuilt models (mlc-ai#767)
  Improve code completion experience (mlc-ai#772)
  Automatically set 'offset' parameter if 'messages' parameter is set (mlc-ai#754)
  Update tokenizers-cpp to latest and fix rust build error (mlc-ai#762)
  [Utils] Skip generating benchmark scripts in cases (mlc-ai#759)
  [Android] Add libOpenCL-pixel for supporintg Pixel phones. (mlc-ai#723)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sudeepag sudeepag sudeepag approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@demattosanthony @sudeepag