-
Notifications
You must be signed in to change notification settings - Fork 6
Labels
Description
Currently MLC skips a dataclass field if its name starts with an underscore:
mlc-python/python/mlc/dataclasses/utils.py
Lines 154 to 155 in a0eb687
| if field_name.startswith("_"): | |
| continue |
This could be a pretty surprising footgun given downstream applications may use the underscore _ convention quite a lot.
There's no fundamental reason MLC has to skip _ fields AFAICT, so could you please reconsider this convention? If MLC really wants to support skipped fields, how about naming them as _mlc_* instead?