Compute emissions based on ongoing carbon intensity#1050
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1050 +/- ##
==========================================
+ Coverage 68.51% 68.73% +0.21%
==========================================
Files 41 41
Lines 3862 3873 +11
==========================================
+ Hits 2646 2662 +16
+ Misses 1216 1211 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
414f160 to
370327d
Compare
|
Thank you ! |
Could you elaborate on this, I think I'm missing something? Are you referring to the time it takes to call |
370327d to
cc62d32
Compare
|
Sorry, you are absolutely right, the Perf improvement is another subject. |
Description
Compute emissions based on ongoing carbon intensity samples, rather than just taking the latest value and applying it to all energy consumption every time.
Related Issue
Please link to the issue this PR resolves: #994
Motivation and Context
Improves emission accuracy over long runs.
How Has This Been Tested?
Added a new test and ran all existing tests.
Screenshots (if appropriate):
Types of changes
What types of changes does your code introduce? Put an
xin all the boxes that apply:Checklist:
Go over all the following points, and put an
xin all the boxes that apply.