Merged
Conversation
Co-authored-by: benoit-cty <6603048+benoit-cty@users.noreply.github.com>
SaboniAmine
approved these changes
Mar 17, 2026
Member
SaboniAmine
left a comment
There was a problem hiding this comment.
LGTM, thanks! You could also add the M5 reference too, as they are now available to the public.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1112 +/- ##
==========================================
+ Coverage 78.25% 78.57% +0.31%
==========================================
Files 38 38
Lines 3638 3640 +2
==========================================
+ Hits 2847 2860 +13
+ Misses 791 780 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Switched to a RegExp so M10 is already supported :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple M4 chips were not recognized in the Apple Silicon detection logic, causing M4 users to receive incorrect install instructions when
powermetricswasn't configured.Changes
codecarbon/core/resource_tracker.py: Added"M4"to the Apple Silicon chip check in_get_install_instructions. Also refactored the chainedorconditions to useany()for maintainability:docs/introduction/methodology.md: Updated Apple Silicon chip list from(M1, M2)to(M1, M2, M3, M4).✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.