Default num_ops_ to 0 #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Author
|
recheck |
6 similar comments
Author
|
recheck |
Author
|
recheck |
Author
|
recheck |
Author
|
recheck |
Author
|
recheck |
Author
|
recheck |
Contributor
|
LGTM |
Contributor
|
@przemekbary - can you please sign the MLC CLA so we can then merge this in> |
Author
|
Hi @tushar-krishna ! |
Contributor
|
The recent protobuf PR should have fixed the unittest build error .. let me check.. |
Author
|
recheck |
Author
|
Hi @tushar-krishna ! |
Contributor
|
Hi @przemekbary could you rebase your pr onto the newest main? The failing checks are solved by #202. |
przemekbary
force-pushed
the
przemekbary_numops_fix
branch
from
9c3752a to
277ba61
Compare
Author
|
@jinsun-yoo - I rebased |
Author
|
recheck |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It was noticed that the debug and realease build were incoherent in terms of execution flow. The reason was narrowed down to num_ops_ being uninitialized, which triggered the astra-sim to take a different branch here:
https://github.com/astra-sim/astra-sim/blob/tutorial-hoti2024/astra-sim/workload/Workload.cc#L126
Test Plan
Run gcc sanitizer and check if the value is initialized.