Skip to content

feat : gpt-oss-120b end to end run with accuracy and perf.#107

Merged
arekay-nv merged 4 commits intomainfrom
arekay/gpt-end-to-end
Jan 28, 2026
Merged

feat : gpt-oss-120b end to end run with accuracy and perf.#107
arekay-nv merged 4 commits intomainfrom
arekay/gpt-end-to-end

Conversation

@arekay-nv
Copy link
Copy Markdown
Collaborator

What does this PR do?

To run gpt-oss-120b with the MLPerf datasets, follow the following steps:

Launch LiveCodeBench evaluator service

The live code bench service isolates the code testing environment from the host environment and provides a service that will execute the code on the provided inputs. See LCB Readme for more details. To launch the service, we must log into docker to get the hardened image, build the service image, and launch the service:

docker login dhi.io -u <YOUR DOCKER USERNAME>
echo "$HF_TOKEN" > /tmp/.hf_token

docker build \
  -f src/inference_endpoint/evaluation/livecodebench/lcb_serve.dockerfile \
  --secret id=HF_TOKEN,src=/tmp/.hf_token \
  -t lcb-service \
  src/inference_endpoint/evaluation/livecodebench
  
docker run \
  --rm \
  -p 13835:13835 \
  lcb-service

Next, we launch the llm inference service of our choice - for instance SGLang with gpt-oss-120b:

docker run --runtime nvidia --gpus all --net host  -v ${HF_HOME}:/root/.cache/huggingface     --env "HUGGING_FACE_HUB_TOKEN=$HF_TOKEN"     --ipc=host lmsysorg/sglang:latest python3 -m sglang.launch_server --model-path ${MODEL_NAME} --host 0.0.0.0 

Once the server is up, we can launch the inference benchmark via:

inference-endpoint benchmark from-config -c examples/04_GPTOSS120B_Example/sglang_gptoss_120b_example.yaml

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor/cleanup

Related issues

Testing

  • Tests added/updated
  • All tests pass locally
  • Manual testing completed

Checklist

  • Code follows project style
  • Pre-commit hooks pass
  • Documentation updated (if needed)

Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
@arekay-nv arekay-nv requested a review from a team as a code owner January 28, 2026 19:58
Copilot AI review requested due to automatic review settings January 28, 2026 19:58
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 28, 2026

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@github-actions github-actions bot requested a review from nvzhihanj January 28, 2026 19:59
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @arekay-nv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive support for end-to-end benchmarking of the gpt-oss-120b model within the MLPerf inference endpoint system. It provides a new example configuration that integrates SGLang and vLLM, alongside necessary Dockerfile enhancements for a robust development environment. Furthermore, the changes refine the reporting mechanism to offer both concise console summaries and detailed file-based reports, improving the usability and traceability of benchmark results.

Highlights

  • GPT-OSS-120B Benchmarking Configuration: The example YAML for gpt-oss-120b now includes detailed instructions for launching SGLang and vLLM servers, and enables the livecodebench::gptoss accuracy dataset.
  • Enhanced Development Dockerfile: The development Dockerfile (Dockerfile.dev) has been updated to include HF_TOKEN support, necessary system tools (git, sudo), and passwordless sudo for the appuser, streamlining the development environment setup.
  • Flexible Report Generation: The reporting system has been improved to allow for both console summary output and detailed report saving to a file, with configurable newline characters for better file formatting.
  • Accuracy Configuration Schema Update: The ground_truth field in the AccuracyConfig schema is now optional, providing more flexibility for different evaluation methods.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables end-to-end benchmarking of the gpt-oss-120b model with MLPerf datasets, incorporating both accuracy and performance testing capabilities. The changes add LiveCodeBench evaluation support and improve reporting functionality.

Changes:

  • Enhanced report output to support file writing with proper newline handling
  • Added LiveCodeBench scorer with ground truth validation
  • Made ground_truth configuration optional to support different evaluation methods
  • Updated development Docker configuration for GPU access and improved permissions

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/inference_endpoint/metrics/reporter.py Added newline and summary_only parameters to enable proper file-based report output
src/inference_endpoint/load_generator/session.py Implemented report export to text file alongside console display
src/inference_endpoint/evaluation/scoring.py Added ground_truth_column validation for LiveCodeBenchScorer
src/inference_endpoint/config/schema.py Changed ground_truth field to optional to support evaluators that don't require it
scripts/Dockerfile.dev Enhanced Docker dev environment with GPU support, git, sudo access, and examples directory
examples/04_GPTOSS120B_Example/sglang_gptoss_120b_example.yaml Enabled LiveCodeBench evaluation and added comprehensive launch instructions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables end-to-end runs for "gpt-oss-120b" with accuracy and performance evaluation, introducing new configurations and reporting mechanisms. While the core functionality looks solid, a security audit identified critical issues related to insecure data handling and access control. Specifically, the use of unvalidated paths for report generation could lead to arbitrary file writes or application crashes, and the granting of passwordless sudo access in the development Dockerfile poses a significant privilege escalation risk, particularly given the project's focus on executing untrusted LLM-generated code. Additionally, the development Dockerfile could be improved for better security, maintainability, and clarity, including safer sudo permission grants and clearer Hugging Face token handling. A minor duplication in the new example YAML file also needs cleanup.

Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
@arekay-nv arekay-nv merged commit 8b1cbec into main Jan 28, 2026
4 checks passed
@arekay-nv arekay-nv deleted the arekay/gpt-end-to-end branch January 28, 2026 21:42
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants