EventRecorder changes to support evaluators and reasoning strings#48
EventRecorder changes to support evaluators and reasoning strings#48nv-alicheng merged 9 commits intomainfrom
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Summary of ChangesHello @nv-alicheng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the event recording and reporting system to improve the robustness and utility of performance and accuracy metrics. By transitioning from a simple JSONL file to a SQLite database for event storage, the system can now capture more detailed information, including reasoning sequences. Furthermore, the introduction of a dedicated event to stop performance tracking allows for more accurate and controlled measurement of performance, ensuring that only relevant samples contribute to the final metrics. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the event recording system to use a SQLite database (EventDB) instead of a JSONL file for logging outputs. This change supports more structured data, including 'reasoning' sequences for evaluators. A new STOP_PERFORMANCE_TRACKING event is introduced to allow for more precise performance measurement by excluding samples issued after a certain point. The changes are extensive, touching event generation, session management, and metrics reporting. My review focuses on the correctness and maintainability of these new implementations. I've found a critical bug in the session logic and a couple of medium-severity issues related to type hints and code duplication that should be addressed.
arekay-nv
left a comment
There was a problem hiding this comment.
Partial review. Will followup later.
3f99805 to
5bcdd3e
Compare
5bcdd3e to
32dab76
Compare
…pport accuracy datasets, move output recording to EventDB from JSONL
…ch similar errors in the future
…rule for QueryResult
ae1b500 to
07a6d50
Compare
What does this PR do?
Type of change
Related issues
Testing
Checklist