Skip to content

feature: Add gpt-oss-120b example#64

Merged
arekay-nv merged 3 commits intomainfrom
arekay/gpt-oss-120b-example
Jan 2, 2026
Merged

feature: Add gpt-oss-120b example#64
arekay-nv merged 3 commits intomainfrom
arekay/gpt-oss-120b-example

Conversation

@arekay-nv
Copy link
Copy Markdown
Collaborator

@arekay-nv arekay-nv commented Dec 18, 2025

What does this PR do?

Adds a gpt-oss-120b example compatible with the LLM working groups proposal.
Performance and accuracy datasets added via git-lfs

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Refactor/cleanup

Related issues

Testing

  • Tests added/updated
  • All tests pass locally
  • Manual testing completed

Checklist

  • Code follows project style
  • Pre-commit hooks pass
  • Documentation updated (if needed)

@arekay-nv arekay-nv requested a review from a team as a code owner December 18, 2025 19:12
Copilot AI review requested due to automatic review settings December 18, 2025 19:12
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 18, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@github-actions github-actions bot requested a review from nvzhihanj December 18, 2025 19:13
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @arekay-nv, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new example for benchmarking the gpt-oss-120b model, aligning with LLM working group proposals. It provides a comprehensive YAML configuration file that defines model parameters, specifies the dataset for performance testing, sets runtime parameters for evaluation, and outlines the metrics to be collected. This addition facilitates standardized testing and performance measurement for the gpt-oss-120b model.

Highlights

  • New Example Addition: A new example directory, 04_GPTOSS120B_Example, has been added to support benchmarking for the gpt-oss-120b model.
  • Benchmark Configuration: A new YAML configuration file, gptoss_120b_example.yaml, is introduced to define the benchmark settings for gpt-oss-120b. This includes model parameters, dataset paths, runtime settings, and metrics to be collected.
  • Performance Settings: The configuration specifies performance evaluation settings such as a target concurrency of 512, minimum and maximum run durations, and random seeds for scheduling and data loading.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@arekay-nv arekay-nv force-pushed the arekay/gpt-oss-120b-example branch from 8a2d1d2 to a750ece Compare December 18, 2025 19:13
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new example configuration for benchmarking gpt-oss-120b. My review identifies a couple of issues in the new YAML configuration file. The specified benchmark durations are extremely short and inconsistent with the comments, which could lead to skewed or meaningless results. Additionally, the report directory name is hardcoded with a specific date, which reduces the reusability of this example. I've provided suggestions to align the durations with their descriptions and to make the directory name more generic.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new example configuration for benchmarking the GPT-OSS-120B model, providing a reference implementation for LLM working group proposals. The example includes performance testing setup with concurrent load patterns and comprehensive metric collection.

Key Changes:

  • Added gpt-oss-120b-benchmark YAML configuration with model parameters and runtime settings
  • Configured performance benchmarking with 512 concurrent connections targeting the 120B parameter model
  • Set up metric collection for throughput, latency, TTFT, and TPOT measurements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@arekay-nv arekay-nv force-pushed the arekay/gpt-oss-120b-example branch from a750ece to b2220c5 Compare December 18, 2025 19:14
Copilot AI review requested due to automatic review settings December 18, 2025 19:32
@arekay-nv arekay-nv force-pushed the arekay/gpt-oss-120b-example branch from b2220c5 to f173b89 Compare December 18, 2025 19:32
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@arekay-nv arekay-nv force-pushed the arekay/gpt-oss-120b-example branch from f173b89 to 1895a17 Compare December 18, 2025 19:41
Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
Copilot AI review requested due to automatic review settings December 19, 2025 15:16
@arekay-nv arekay-nv force-pushed the arekay/gpt-oss-120b-example branch from 1895a17 to 879674f Compare December 19, 2025 15:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Rashid Kaleem <230885705+arekay-nv@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 2, 2026 23:26
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@arekay-nv arekay-nv merged commit 135f7a0 into main Jan 2, 2026
4 checks passed
@arekay-nv arekay-nv deleted the arekay/gpt-oss-120b-example branch January 2, 2026 23:30
@github-actions github-actions bot locked and limited conversation to collaborators Jan 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants