Add support for SGLang generate API to compare and match GPT-OSS reference implementation in v6.0 (part of #4)#80
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Summary of ChangesHello @nv-alicheng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the system's flexibility by integrating support for the SGLang Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for the SGLang /generate API and refactors worker.py to better accommodate multiple API types. The changes are well-structured, with the introduction of an APIType enum and dedicated SSE accumulator classes being a significant improvement for modularity. However, I've identified a critical bug in the SGLangSSEAccumulator that prevents streaming from working as intended. Additionally, I have a couple of medium-severity suggestions to enhance documentation clarity and code maintainability. Once the critical bug is addressed, this will be a solid contribution.
9b0cf6b to
4484187
Compare
… since CICD will not change the .yml until merge
4484187 to
5bddcda
Compare
What does this PR do?
Modularizes worker.py to more easily add support for multiple APIs, adds support for SGLang's /generate API endpoint.
#4
Tested locally running GPT-OSS on H200x8.
Type of change
Related issues
Testing
Checklist