Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Summary of ChangesHello @nv-alicheng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the evaluation capabilities by incorporating LiveCodeBench (LCB) into the SGLang framework. It establishes a robust mechanism for evaluating code generation models by introducing a dedicated service for secure code execution, a specialized extractor for Python code, and seamlessly integrating LCB into the comprehensive accuracy benchmark suite. This lays the groundwork for more rigorous and secure code-based model assessments. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for LiveCodeBench (LCB) evaluation. The changes include a new evaluation script for LCB, a setup script, the core evaluation logic in lcb_serve.py, a new PythonCodeExtractor, and a LiveCodeBenchScorer. The main benchmark runner is also updated to include LCB. My review focuses on improving robustness, configurability, and correctness. I've identified several hardcoded paths that should be made configurable, a bug where a timeout parameter is ignored, and some opportunities for code improvement and making the implementation less brittle.
src/inference_endpoint/dataset_manager/predefined/livecodebench/lcb_serve.py
Outdated
Show resolved
Hide resolved
src/inference_endpoint/dataset_manager/predefined/livecodebench/lcb_serve.py
Outdated
Show resolved
Hide resolved
src/inference_endpoint/dataset_manager/predefined/livecodebench/lcb_serve.py
Outdated
Show resolved
Hide resolved
src/inference_endpoint/dataset_manager/predefined/livecodebench/lcb_serve.py
Show resolved
Hide resolved
…to avoid environment corruption
…for LCBScorer with option to silence
What does this PR do?
Adds LCB evaluation functionality via LCBServe. Followup PR will move LCBServe to a containerized microservice.
Type of change
Related issues
Testing
Checklist