Implement LoadGen server_coalesce_queries flag #618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvpohanh
changed the title
tjablin
suggested changes
Jun 11, 2020
Contributor
Author
|
Unfortunately, the multi-thread IssueQuery() needs to wait until tomorrow.... Still debugging :( |
This was referenced Jun 15, 2020
Contributor
|
How do I turn this feature on and off by a user? |
Contributor
Author
|
@christ1ne By default it's off. To turn on, set the |
Contributor
Author
|
@christ1ne @guschmue @tjablin Is it fine if we merge this first? I think this feature has less concern and it will make #620 look cleaner. Thanks! |
Contributor
|
fine with me |
Contributor
Author
Contributor
|
@tjablin ... good with it? |
Contributor
|
Test at my local, no obvious performance degradation observed when this patch is applied and whether server_coalesce_queries flag is used or not. |
Contributor
Author
|
@tjablin Sorry for pinging. I have addressed all your comments. Could we merge this PR? Thanks |
guschmue
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
sleep_until()if in Server scenario and if the current time has already passed the current query's scheduled time.server_coalesce_queriesflag. When this flag is set to true, LoadGen will issue multiple samples per query when the current time has already passed multiple queries' scheduled timestamps.