Skip to content

Issue #141#168

Merged
anandhu-eng merged 5 commits intomlcommons:devfrom
sinanshamsudheen:issue-141
Aug 23, 2025
Merged

Issue #141#168
anandhu-eng merged 5 commits intomlcommons:devfrom
sinanshamsudheen:issue-141

Conversation

@sinanshamsudheen
Copy link
Contributor

📋 PR Summary - Add Description Field Support for Scripts

�� Issue Addressed

Closes #141 - "Can we have a description field in the metadata of a script?"

✨ New Features

  • mlc describe script --tags=<tags> - Quick description lookup
  • Enhanced mlc show script - Now displays description field when present
  • Graceful fallback - Shows "No description available" for missing descriptions

🔧 Implementation Details

  • Added describe() method to ScriptAction class
  • Updated show() method to include description in metadata display
  • Registered describe action in CLI parser
  • Updated documentation across all relevant files

📁 Files Changed

  • mlc/script_action.py - Core implementation (+40 lines)
  • mlc/main.py - CLI registration (+1 action)
  • README.md - Updated action table
  • docs/targets/script/index.md - Added documentation

✅ Testing

  • ✅ Tested with real MLPerf repository
  • ✅ Verified help system integration
  • ✅ Confirmed backward compatibility
  • ✅ Tested multiple script scenarios

�� Benefits

  • Minimal changes - Only 4 files modified
  • Consistent pattern - Follows existing find vs show relationship
  • User-friendly - Quick access to script descriptions
  • Extensible - Easy to add descriptions to any script's meta.yaml

📊 Stats

  • 4 files changed
  • 57 insertions, 8 deletions
  • Zero breaking changes
  • Fully backward compatible

@sinanshamsudheen sinanshamsudheen requested a review from a team as a code owner August 2, 2025 09:16
@github-actions
Copy link

github-actions bot commented Aug 2, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@anandhu-eng
Copy link
Contributor

Hi @sinanshamsudheen , thanks for the PR.

I think we could eliminate the describe action from MLCFlow and include it with show action.

@arjunsuresh
Copy link
Contributor

Thank you @sinanshamsudheen for the PR. As Anandhu told it makes sense for the description to be part of the show action but the describe action looks harmless. Please fill in the CLA form and then we can merge the PR.

@anandhu-eng anandhu-eng mentioned this pull request Aug 23, 2025
@anandhu-eng
Copy link
Contributor

Merging the PR as CLA is approved

@anandhu-eng anandhu-eng merged commit 14d935a into mlcommons:dev Aug 23, 2025
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants