Add mark-tmp cache action#238
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/mlcommons/mlcflow/sessions/b9e64b25-2fc2-4969-9147-9ae95e868669 Co-authored-by: arjunsuresh <4791823+arjunsuresh@users.noreply.github.com>
Agent-Logs-Url: https://github.com/mlcommons/mlcflow/sessions/b9e64b25-2fc2-4969-9147-9ae95e868669 Co-authored-by: arjunsuresh <4791823+arjunsuresh@users.noreply.github.com>
Agent-Logs-Url: https://github.com/mlcommons/mlcflow/sessions/b9e64b25-2fc2-4969-9147-9ae95e868669 Co-authored-by: arjunsuresh <4791823+arjunsuresh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add action to invalidate cache with tmp tag
Add May 22, 2026
mark-tmp cache action
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
🤖 AI PR Review Summary\n\nThis PR introduces a new 'mark-tmp' action for the cache target, allowing users to tag cache entries as temporary without deleting files. It updates CLI parsing, documentation, and adds a comprehensive test for the new feature. The design is straightforward, but risks include potential metadata corruption if saving fails and ensuring backward compatibility with existing cache metadata formats. |
🤖 AI PR Review Summary\n\nThis PR adds a new 'mark-tmp' action to the cache target, allowing users to tag cache entries as temporary without deleting their contents. It updates the CLI parser, documentation, and cache action class to support this feature. A new test verifies that the 'tmp' tag is added correctly and avoids duplicates. The design is straightforward, but risks include ensuring metadata consistency and handling concurrent modifications. The PR improves cache management flexibility with minimal risk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a cache action for the workflow discussed in the issue: mark matching cache entries as
tmpinstead of deleting them, so users can force cache refresh/reuse flows without manually editing cache metadata. The CLI now supports the hyphenated action name agreed on in the discussion.CLI
mlc mark-tmp cacheCache behavior
CacheAction.mark_tmp()tmptagtmptags on repeated runsDocs / help
mark-tmpCoverage
tmpto cache metadata✅ PR Checklist
dev📌 Note: PRs must be raised against
dev. Do not commit directly tomain.✅ Testing & CI
📚 Documentation
📁 File Hygiene & Output Handling
🛡️ Safety & Security
🙌 Contribution Hygiene
Fixes #orCloses #.