Skip to content

Add a basic Meta Llama SUT#1065

Merged
wpietri merged 3 commits into
mainfrom
add-llama-sut
Jun 4, 2025
Merged

Add a basic Meta Llama SUT#1065
wpietri merged 3 commits into
mainfrom
add-llama-sut

Conversation

@wpietri
Copy link
Copy Markdown
Contributor

@wpietri wpietri commented Jun 4, 2025

This uses Meta's client to add support for their Meta LLama hosting service so that we can run some of their beta models.

It's my first time writing a SUT and it wasn't clear to me which bits are necessary and which aren't, so this is pretty minimal. What else does it need?

I certainly should add more retrying. What's our current best practice?

Also, I'm doing this directly in the main code base, like the Together SUT. Is there a reason to make it a plugin?

@wpietri wpietri requested a review from a team as a code owner June 4, 2025 14:45
@wpietri wpietri had a problem deploying to Scheduled Testing June 4, 2025 14:45 — with GitHub Actions Failure
@wpietri wpietri requested a review from bkorycki June 4, 2025 14:45
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@wpietri wpietri requested a review from rogthefrog June 4, 2025 16:29
@wpietri wpietri temporarily deployed to Scheduled Testing June 4, 2025 16:37 — with GitHub Actions Inactive
@wpietri wpietri temporarily deployed to Scheduled Testing June 4, 2025 16:37 — with GitHub Actions Inactive
@wpietri wpietri temporarily deployed to Scheduled Testing June 4, 2025 16:37 — with GitHub Actions Inactive
Copy link
Copy Markdown
Contributor

@bkorycki bkorycki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay congrats on your first SUT!

It's my first time writing a SUT and it wasn't clear to me which bits are necessary and which aren't, so this is pretty minimal. What else does it need?

This SUT has everything it needs!

I certainly should add more retrying. What's our current best practice?

Most SUTs that use python clients use the @retry decorator from retry_decorator.py. You can look at the OpenAI SUT for an example.

Also, I'm doing this directly in the main code base, like the Together SUT. Is there a reason to make it a plugin?

Like we discussed, the original reason for making things plugins isn't really important anymore (i.e. making it easier/more lightweight for developers using the library).
I think the only reason to make it a plugin now is to be consistent with the rest of the codebase. And I think it makes it easier to find. But it's up to you.

Comment thread src/modelgauge/suts/meta_llama_client.py Outdated
Comment thread src/modelgauge/suts/meta_llama_client.py Outdated
Comment thread src/modelgauge/suts/meta_llama_client.py Outdated
Responding to feedback
@wpietri wpietri temporarily deployed to Scheduled Testing June 4, 2025 18:04 — with GitHub Actions Inactive
@wpietri wpietri temporarily deployed to Scheduled Testing June 4, 2025 18:04 — with GitHub Actions Inactive
@wpietri wpietri temporarily deployed to Scheduled Testing June 4, 2025 18:04 — with GitHub Actions Inactive
@wpietri wpietri requested a review from bkorycki June 4, 2025 18:05
@wpietri wpietri merged commit d5386c3 into main Jun 4, 2025
4 checks passed
@wpietri wpietri deleted the add-llama-sut branch June 4, 2025 18:59
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants