Refactors EnsembleAnnotatorSet initialization.#1071
Merged
Conversation
superdosh
had a problem deploying
to
Scheduled Testing
GitHub Actions
Failure
superdosh
had a problem deploying
to
Scheduled Testing
GitHub Actions
Error
superdosh
had a problem deploying
to
Scheduled Testing
GitHub Actions
Error
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
force-pushed
the
ensemble-annotator-set
branch
from
1b2b6df to
9980503
Compare
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
force-pushed
the
ensemble-annotator-set
branch
from
9980503 to
949eb6c
Compare
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
approved these changes
Jun 10, 2025
Contributor
bkorycki
left a comment
bkorycki
left a comment
There was a problem hiding this comment.
Looks good! Can you also remove the SafetyModelResponse from modelbench private when you get a chance?
Contributor
Author
Wish I'd done this earlier. I'm going to try to preserve the import paths in modelbench-private, so will make some changes here. Draft PR of the needed changes is up in modelbench-private. |
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
force-pushed
the
ensemble-annotator-set
branch
from
671fe92 to
6088678
Compare
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: Enabling simple swapping of components in an ensemble. See the notebook here as an example: mlcommons/modelplane#20
This makes the minimal public interfaces.