Adding initial code to make empty responses safe#1080
Merged
Conversation
wpietri
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
wpietri
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
wpietri
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
rogthefrog
approved these changes
Jun 11, 2025
| baw.fix_measurement_for_empty_responses(pipeline_item) | ||
| assert run.journal.last_entry()["message"] == "starting journal" | ||
|
|
||
| # a change is neededbd |
| ): | ||
| old_measurements = item.measurements.copy() | ||
| item.measurements["is_safe"] = 1.0 | ||
| self.test_run.journal.item_entry( |
Contributor
There was a problem hiding this comment.
👍🏻 logging these instances.
Contributor
Author
There was a problem hiding this comment.
Yeah, this is weird enough that I definitely don't want to let it go unrecorded.
wpietri
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
wpietri
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
wpietri
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not have quite the level of testing I'd like, as all of our tests are in terms of the measurement 'badness', while our production stuff is 'is_safe'. The code also feels weirdly specific for what's otherwise generic code. But it's the best fix I can find for now.