Fix items with empty responses.#1521
Merged
Merged
Conversation
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
force-pushed
the
empty-response-fix
branch
from
4cf6536 to
6114145
Compare
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
superdosh
had a problem deploying
to
Scheduled Testing
GitHub Actions
Failure
superdosh
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
bkorycki
approved these changes
May 1, 2026
Contributor
bkorycki
left a comment
bkorycki
left a comment
There was a problem hiding this comment.
looks good for an immediate fix.
rogthefrog
approved these changes
May 1, 2026
| # log if any annotations were overridden | ||
| if overridden_annotators: | ||
| self.test_run.journal.item_entry( | ||
| "overrode item annotation", |
Contributor
There was a problem hiding this comment.
Does the consistency checker reference journal entries by label? If so, it may be good to check if changing "overrode item quality" to "overrode item annotation" will break anything there.
Contributor
Author
There was a problem hiding this comment.
The only place I see "overrode" in the code base is here and in the test also in this PR. So I don't think anything else references it. That seems safe right?
| # overwrite the annotations as unsafe | ||
| for annotator_uid in pipeline_item.annotations: | ||
| pipeline_item.annotations[annotator_uid].is_safe = False | ||
| # re-run the handle, which should populate the measurement (and fix) |
Contributor
Author
|
Follow up here: https://github.com/mlcommons/sugar/issues/477 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior fix only updated the item's measurement, not the underlying annotations. This does that and also journals it as needed.
The other change is that the update is applied at the end of
collect_annotations, NOT inhandle_itemanymore, so the measurement is done on the corrected item.