Small modelbench fixes#978
Merged
Merged
Conversation
Allow changing number of threads when running benchmarks. Speed up `retry` tests and other sleeping tests.
wpietri
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
wpietri
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
wpietri
temporarily deployed
to
Scheduled Testing
GitHub Actions
Inactive
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
rogthefrog
approved these changes
Apr 14, 2025
|
|
||
| class AnnotatorWorkers(CachingPipe): | ||
| def __init__(self, annotators: dict[str, Annotator], workers=None, cache_path=None): | ||
| self.sleep_time = 10 |
Contributor
There was a problem hiding this comment.
Should it be a class-level setting?
Contributor
Author
There was a problem hiding this comment.
Probably not, as the use for it is to change one instance for a test.
|
|
||
| class PromptSutWorkers(CachingPipe): | ||
| def __init__(self, suts: dict[str, SUT], sut_options: Optional[SUTOptions] = None, workers=None, cache_path=None): | ||
| self.sleep_time = 10 |
Contributor
There was a problem hiding this comment.
Same question as above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make together retry more. Allow changing number of threads when running benchmarks. Speed up
retrytests and other sleeping tests.