Skip to content

Conversation

@bkorycki
Copy link
Contributor

@bkorycki bkorycki commented Jul 8, 2025

No description provided.

@bkorycki bkorycki requested a review from superdosh July 8, 2025 22:21
@bkorycki bkorycki requested a review from a team as a code owner July 8, 2025 22:21
@github-actions
Copy link

github-actions bot commented Jul 8, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

except Exception as e:
print(f"Failed to log stats for {annotator_uid}: {e}")
with AnnotationDataset(data_path, "r") as dataset:
for item in dataset:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not totally sure how this works when there are multiple annotators? If I'm reading the __iter__ in modelgauge.dataset correctly, each row produces one item, but I think if there are multiple annotators, each row will contain multiple annotator_uids? Or did that change too in the modelgauge PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That changed in the modelgauge PR! Every row is one response and one annotation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's probably why the randomness changed! Since before it was looping row, and then a for loop around the annotators per row, but the order of the annotators may not match the order modelgauge is now producing.

I'm good on this then!

@bkorycki bkorycki requested a review from superdosh July 9, 2025 16:25
@bkorycki bkorycki merged commit 6a5641a into main Jul 9, 2025
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants