🔒 Secure Process Launch and URL Opening#1
Conversation
- Implement SafeProcess utility for centralized process management - Validate URL schemes (http/https only) before opening - Use Browser.Default.OpenAsync for external links - Set UseShellExecute = false for internal process launches - Refactor call sites in SettingsPage, ItemDetailPage, ModManagerPage, EditorPage, and SteamWorkshopService
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Implement SafeProcess utility for centralized process management - Validate URL schemes (http/https only) before opening - Use Browser.Default.OpenAsync for external links - Set UseShellExecute = false for internal process launches - Refactor call sites in SettingsPage, ItemDetailPage, ModManagerPage, EditorPage, and SteamWorkshopService - Fix CI failure by adding administration: read permission and error handling to runner selection script
🎯 What: Fixed insecure use of
Process.StartwithUseShellExecute = truefor unvalidated or external inputs.UseShellExecute = truewith untrusted strings allows the OS shell to execute malicious URI schemes (e.g.,javascript:,file://) or unintended file types, potentially leading to arbitrary code execution or information disclosure.🛡️ Solution:
SafeProcessutility class to centralize safe process and URL handling.httpandhttps.Process.Startcalls withMicrosoft.Maui.ApplicationModel.Browser.Default.OpenAsyncfor URLs.UseShellExecute = falsefor internal executable launches (like restarting the app or opening explorer).PR created automatically by Jules for task 14022166927548578863 started by @mleem97