Skip to content

[LIBSEARCH-1158] SiteImprove -- two minor MGet It problems #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bertrama merged 3 commits into from
Mar 25, 2026
Merged

[LIBSEARCH-1158] SiteImprove -- two minor MGet It problems #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11e13a6
Wrapping `m-chat` in an `aside` element.
erinesullivan Mar 16, 2026
6949a28
Wrapping `<h1>` parent container in a `section` element.
erinesullivan Mar 16, 2026
67033a1
Removing `margin: 0 auto` from the `.skip-links` class to let element…
erinesullivan Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/assets/stylesheets/mgetit/_skip_links.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
.skip-links {
background: var(--color-blue-400);
padding: var(--space-small);
margin: 0 auto;
}

.skip-links ul {
Expand Down
12 changes: 7 additions & 5 deletions lib/views/application.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,30 +68,32 @@
<%= erb :header, locals: {request: request} %>

<% if !defined?(callout) || callout.nil? %>
<div class="heading-container">
<section class="heading-container">
<div class="container">
<h1 class="site-heading" id="maincontent" tabindex="-1">MGet It</h1>
<p class="site-subheading">
Your pathway to electronic resources
</p>
</div>
</div>
</section>
<% else %>
<div class="callout spacing-top-bottom-2">
<section class="callout spacing-top-bottom-2">
<div class="page-container">
<h1 class="no-margin" id="maincontent" tabindex="-1"><%= title %></h1>
<p>
<%= callout %>
</p>
</div>
</div>
</section>
<% end %>

<main class="container">
<%= yield %>
</main>

<%= erb :footer, locals: {request: request} %>
<m-chat id="chat"></m-chat>
<aside aria-label="Ask a Librarian Chat">
<m-chat id="chat"></m-chat>
</aside>
</body>
</html>
1 change: 0 additions & 1 deletion public/citation-linker/assets/stylesheets/main.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ textarea {
.skip-links {
background: var(--color-blue-400);
padding: var(--space-small);
margin: 0 auto;
}

.skip-links ul {
Expand Down
8 changes: 5 additions & 3 deletions public/citation-linker/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,14 +68,14 @@
<m-universal-header></m-universal-header>
<m-website-header variant="dark" name="MGet It"></m-website-header>

<div class="callout spacing-top-bottom-2">
<section class="callout spacing-top-bottom-2">
<div class="page-container">
<h1 class="no-margin" id="maincontent" tabindex="-1">Citation Linker</h1>
<p>
Find a journal article or book by citation information. We'll send you off to MGet It when you're finished with the form.
</p>
</div>
</div>
</section>

<main class="page-container">

Expand Down Expand Up @@ -324,7 +324,9 @@ <h2>University of Michigan Library</h2>
</div>
</footer>

<m-chat id="chat"></m-chat>
<aside aria-label="Ask a Librarian Chat">
<m-chat id="chat"></m-chat>
</aside>

<script src="https://unpkg.com/expect/umd/expect.min.js"></script> <!-- for development only -->
<script src="assets/javascript/vendor/underscore.js"></script>
Expand Down
1 change: 0 additions & 1 deletion public/citation-linker/stylesheets/partials/_skip_links.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
.skip-links {
background: var(--color-blue-400);
padding: var(--space-small);
margin: 0 auto;
}

.skip-links ul {
Expand Down
Loading