[LIBSEARCH-1141] Consolidate Summary Holdings Notes display for items in new consolidated Offsite Shelving Location (front end display)#574
Merged
erinesullivan merged 3 commits intomasterfrom Mar 5, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
With the consolidation of offsite shelving, there is a likelihood of notes becoming a long list. In order to save vertical space, the
Expandablecomponent has been applied to the unordered list. This will appear on all notes.This pull request resolves LIBSEARCH-1141.
Anything else?
The
captionLinkconditional would always return true becausecaptionLink.textalways exists, which would then print out an empty paragraph. The conditional has been changed see that not onlycaptionLinkexists, but also thehrefproperty.Testing