Skip to content

[LIBSEARCH-1141] Consolidate Summary Holdings Notes display for items in new consolidated Offsite Shelving Location (front end display)#574

Merged
erinesullivan merged 3 commits intomasterfrom
LIBSEARCH-1141-consolidate-summary-holdings-notes-display-for-items-in-new-consolidated-offsite-shelving-location-front-end-display
Mar 5, 2026
Merged

[LIBSEARCH-1141] Consolidate Summary Holdings Notes display for items in new consolidated Offsite Shelving Location (front end display)#574
erinesullivan merged 3 commits intomasterfrom
LIBSEARCH-1141-consolidate-summary-holdings-notes-display-for-items-in-new-consolidated-offsite-shelving-location-front-end-display

Conversation

@erinesullivan
Copy link
Copy Markdown
Contributor

@erinesullivan erinesullivan commented Mar 5, 2026

Overview

With the consolidation of offsite shelving, there is a likelihood of notes becoming a long list. In order to save vertical space, the Expandable component has been applied to the unordered list. This will appear on all notes.

This pull request resolves LIBSEARCH-1141.

Anything else?

The captionLink conditional would always return true because captionLink.text always exists, which would then print out an empty paragraph. The conditional has been changed see that not only captionLink exists, but also the href property.

Testing

  • Make sure the PR is consistent in these browsers:
    • Chrome
    • Firefox
    • Safari
    • Edge
  • Run accessibility tests:
    • WAVE
    • ARC Toolkit
    • axe DevTools
  • Check out the holdings of a record. Does the expandable button appear on all notes?

@erinesullivan erinesullivan self-assigned this Mar 5, 2026
@erinesullivan erinesullivan added Type: Enhancement javascript Pull requests that update javascript code labels Mar 5, 2026
@erinesullivan erinesullivan merged commit 5f2cda9 into master Mar 5, 2026
9 checks passed
@erinesullivan erinesullivan deleted the LIBSEARCH-1141-consolidate-summary-holdings-notes-display-for-items-in-new-consolidated-offsite-shelving-location-front-end-display branch March 5, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript Pull requests that update javascript code Type: Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant