Issue with CJS default exports

I've tested the exports from this package which fail using require since the default exports in TS are translated to exports.default = BaseRegression when compiling the code to CJS.

The imports work well using the import syntax, so Typescript or esm modules seem to be fine.

Using named exports will cause updates upstream since it will be breaking.

I'm just raising the issue so you may decide or discuss what is the best option.

The only way to keep the same syntax (no named exports) that I find (I think) is to export 2 different index files, one goes to module, one to CommonJS.

The other way, is the named exports.

[targos]

Yeah, a breaking change in this module would be annoying for little benefit.

The only way to keep the same syntax (no named exports) that I find (I think) is to export 2 different index files, one goes to module, one to CommonJS.

Here's my suggestion:

• Keep src, and TS compilation the same.
• Add a new CJS file at the root of the repo which does module.exports = require('./lib/index.js').default
• Add this file to the files array in package.json and set it as the main field.

This is great, thank you. I have noticed that there is a minor bug as well, so I'll quickly submit all, and maybe we can release it.

I've tried this for a while using something like this (since we have more exports in index):

// Purpose: entry point for NodeJS, json.main field.
// this file is ignored by the TS compiler (tsconfig.json)
const allExports = require('./lib/index.js')

module.exports = allExports.default
exports.checkArrayLength = allExports.checkArrayLength
exports.maybeToPrecision = allExports.maybeToPrecision

There is the same error, however, I realised that in this case the js code runs fine, the error is just Typescript.

I'm a bit confused, but I did this mini example in case you want to take a quick look.

So we may need to either trick the compiler, or use two separate ts files (I didn't test this yet.) but you probably have a more solid idea.

[targos]

the error is just Typescript.

What does that mean?

Your code isn't right, though. When you do module.exports = allExports.default, you override the default exports object, so you're not supposed to assign to it afterwards. I suggest:

const allExports = require('./lib/index.js');

module.exports = allExports.default;
Object.assign(module.exports, allExports);

Thanks for the correction. Just to answer the question, by that line I mean this:

But it could be the result of the error that you comment on.

I am not sure why it reads from lib either (with the config file below.)

---

The package.json:

{
  //...
  "main": "index.js",
  "module": "./lib-esm/index.js",
  "types": "./lib/index.d.ts",
  "files": [
    "index.js",
    "src",
    "lib",
    "lib-esm"
  ],
// ...
}

Update

The same type error appears with the changes.