perf: avoid extra array copies in xy median and scan helpers#385
Merged
Conversation
- xMedian: add optional fromIndex/toIndex range so it slices only the needed window internally - xyMedianY / xyMedianYAtXs: pass the range to xMedian instead of building a per-point window (removes the double copy for plain-array input) - xyAlign: compute the weighted x only for the 'weighted' option - xyMaxY / xyMaxYPoint / xyMinYPoint: start the scan after the seed index - xyMedian: guard the exact-half branch against an out-of-bounds read at the last index
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 97.13% 97.16% +0.03%
==========================================
Files 207 208 +1
Lines 4147 4161 +14
Branches 1036 1033 -3
==========================================
+ Hits 4028 4043 +15
+ Misses 115 114 -1
Partials 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanups from reviewing the
xyfolder.xMedian: add optionalfromIndex/toIndexrange so it slices only the needed window internally (backward compatible).xyMedianY/xyMedianYAtXs: pass the range toxMedianinstead of building a per-point window — removes the double copy for plain-array input and drops theArrayBuffer.isViewbranch.xyAlign: compute the weighted x only for the'weighted'option.xyMaxY/xyMaxYPoint/xyMinYPoint: start the scan one index after the seed value.xyMedian: guard the exact-half branch against an out-of-bounds read at the last index.