fix(IlluminaRunFolder): strip A/B side prefix from flowcell segment#82
Merged
fix(IlluminaRunFolder): strip A/B side prefix from flowcell segment#82
Conversation
The previous regex `/\d*-?([A-Z].+)$/` captured from the first uppercase letter, which kept the A/B side prefix intact (e.g. ASC2139476-SC3 instead of SC2139476-SC3). This caused flowcell lookups in nemo to fail. Split into two explicit patterns: - Zero-prefixed (MiSeq): 000000000-XXXXX → XXXXX - Side-prefixed (iSeq, NextSeq, NovaSeq): [AB]XXXXX → XXXXX Added Illumina documentation references for run folder naming conventions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
KingKong1213
approved these changes
Mar 12, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Mar 12, 2026
## [6.6.1](v6.6.0...v6.6.1) (2026-03-12) ### Bug Fixes * **IlluminaRunFolder:** strip A/B side prefix from flowcell segment ([#82](#82)) ([ce8bbaf](ce8bbaf))
|
🎉 This PR is included in version 6.6.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/\d*-?([A-Z].+)$/kept the A/B side prefix intact (e.g.ASC2139476-SC3instead ofSC2139476-SC3), causing flowcell lookups in nemo to fail000000000-XXXXX → XXXXX) and side-prefixed (iSeq/NextSeq/NovaSeq:[AB]XXXXX → XXXXX)Test plan
🤖 Generated with Claude Code