fix(TecanDeckView): MM-Rack ohne Zeile J rendern - #333
Merged
Conversation
MasterMixRack in php-utils uses CoordinateSystem2x16NoJ, whose rows run A-I and K-Q, and limes-api derives the MasterMixBlockItem coordinates from it. Rendering those against a row list containing J put everything from K onwards one row too low, and Q wells fell out of the position lookup without any error. COORDINATE_SYSTEM_2X16 stays as it is, so this only adds a coordinate system rather than changing one.
fischerl
approved these changes
Aug 24, 2026
simbig
marked this pull request as ready for review
August 24, 2026 12:47
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 24, 2026
## [20.6.1](v20.6.0...v20.6.1) (2026-08-24) ### Bug Fixes * **TecanDeckView:** render the master mix rack without row J ([#333](#333)) ([59e46e3](59e46e3))
|
🎉 This PR is included in version 20.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TecanDeckViewrendert den MM-Rack bisher gegen eine Zeilenliste mitJ. Der MM-Rack hat aber keinJ:MasterMixRackin php-utils benutztCoordinateSystem2x16NoJmit den ZeilenA–IundK–Q, undMasterMixBlockItemin limes-api leitet die Koordinaten genau daraus ab.Im released
20.6.0saß deshalb alles abKeine Zeile zu tief, undQ-Wells fielen still aus dem Positions-Lookup —Platesucht die Wells überdata.find(...), ohne Treffer verschwindet das Well einfach.COORDINATE_SYSTEM_2X16bleibt unangetastet, es kommt nur ein Koordinatensystem dazu. Das spiegelt die Struktur in php-utils, woCoordinateSystem2x16undCoordinateSystem2x16NoJebenfalls nebeneinander stehen.Betroffene Consumer in limes-frontend:
M/Qpcr/PipettingDetails.tsxfüttertmmPlateausworklist.masterMixBlockItemsund profitiert direkt.L/SalsaMlpa/Show/Pipetting/Tecan/SalsaMlpaTecanLayout.tsxbenutzt nurA1/B1und ist damit nicht betroffen.Geht als eigener MR vor der GWL-Vorschau raus, damit die Korrektur im Changelog als
fixauftaucht statt im Squash einesfeatzu verschwinden.Test Plan
Story
TecanDeckView: der MM-Rack zeigt die ZeilenA–IundK–Q, und Position 32 liegt aufQ2.