[Frontend Spec] Add allowed artifact path prefixes list to frontend spec#3261
Merged
liranbg merged 5 commits intomlrun:developmentfrom Mar 22, 2023
Merged
Conversation
liranbg
reviewed
Mar 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a parameter to frontend spec called
allowed_artifact_path_prefixes_listwhich is a list of prefixes that the files API supports when requesting to get files. This is done so the UI can filter based on it, and disable download/preview buttons for artifacts that are not located on one of these prefixes.ML-3595