[RemoteRuntime] Fix adding http trigger mode for sync#9332
Merged
gtopper merged 5 commits intomlrun:developmentfrom Feb 18, 2026
Merged
[RemoteRuntime] Fix adding http trigger mode for sync#9332gtopper merged 5 commits intomlrun:developmentfrom
gtopper merged 5 commits intomlrun:developmentfrom
Conversation
gtopper
reviewed
Feb 18, 2026
Collaborator
gtopper
left a comment
There was a problem hiding this comment.
Minor comments – LGTM otherwise!
…ues, added negative case for test_mlrun_function_translation_to_nuclio
gtopper
reviewed
Feb 18, 2026
gtopper
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fix https://iguazio.atlassian.net/browse/ML-12025 adding http trigger mode to trigger spec when using sync mode
🛠️ Changes Made
Added mode field for default http trigger of serving function + adding to
with_httpmethod the mode when sync mode is chosen, by default or explicit✅ Checklist
🧪 Testing
added unit test to check the trigger spec, checked that serving behave as expected for both modes
🔗 References
🚨 Breaking Changes?
🔍️ Additional Notes