Skip to content

[RemoteRuntime] Fix adding http trigger mode for sync#9332

Merged
gtopper merged 5 commits intomlrun:developmentfrom
royischoss:ml-12025
Feb 18, 2026
Merged

[RemoteRuntime] Fix adding http trigger mode for sync#9332
gtopper merged 5 commits intomlrun:developmentfrom
royischoss:ml-12025

Conversation

@royischoss
Copy link
Contributor

@royischoss royischoss commented Feb 17, 2026

📝 Description

Fix https://iguazio.atlassian.net/browse/ML-12025 adding http trigger mode to trigger spec when using sync mode


🛠️ Changes Made

Added mode field for default http trigger of serving function + adding to with_http method the mode when sync mode is chosen, by default or explicit


✅ Checklist

  • I updated the documentation (if applicable)
  • I have tested the changes in this PR
  • I confirmed whether my changes are covered by system tests
    • If yes, I ran all relevant system tests and ensured they passed before submitting this PR
    • I updated existing system tests and/or added new ones if needed to cover my changes
  • If I introduced a deprecation:

🧪 Testing

added unit test to check the trigger spec, checked that serving behave as expected for both modes


🔗 References

  • Ticket link: Ticket
  • Design docs links:
  • External links:

🚨 Breaking Changes?

  • Yes (explain below)
  • No

🔍️ Additional Notes

@royischoss royischoss requested review from a team and TomerShor as code owners February 17, 2026 12:53
@royischoss royischoss changed the title [Runtime] Fix adding mode sync to trigger spec [Runtime] Fix adding http trigger mode for sync Feb 17, 2026
@royischoss royischoss changed the title [Runtime] Fix adding http trigger mode for sync [RemoteRuntime] Fix adding http trigger mode for sync Feb 17, 2026
@royischoss royischoss requested a review from gtopper February 18, 2026 08:40
Copy link
Collaborator

@gtopper gtopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments – LGTM otherwise!

…ues, added negative case for test_mlrun_function_translation_to_nuclio
@gtopper gtopper merged commit c2ac0b1 into mlrun:development Feb 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments