Support microsecond precision in TDEngine databases#555
Merged
gtopper merged 2 commits intomlrun:developmentfrom Mar 27, 2025
Merged
Support microsecond precision in TDEngine databases#555gtopper merged 2 commits intomlrun:developmentfrom
gtopper merged 2 commits intomlrun:developmentfrom
Conversation
A part of the fix for ML-9067.
874b880 to
73c7429
Compare
4df1c59 to
138a9a4
Compare
gtopper
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A part of the work on ML-9067 for storey's
TDEngineTarget.The possible timestamp precisions in TDEngine are:
See:
https://docs.tdengine.com/tdengine-reference/sql-manual/data-types/#timestamp
https://docs.tdengine.com/tdengine-reference/sql-manual/manage-databases/#create-database
We previously supported only ms - TDEngine's default.
The precision is set for the whole database. It is stored in the metadata database:
https://docs.tdengine.com/tdengine-reference/sql-manual/metadata/#ins_databases
Note: the ns precision is not natural in Python, so I do not expect it to be used.
I tested it while running an MLRun system test, and it works.