Skip to content

[FIX] Inconsistent tab selection after page refresh in detail views #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muli-cohen merged 1 commit into from
Feb 24, 2026
Merged

[FIX] Inconsistent tab selection after page refresh in detail views #3567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Artifacts/Artifacts.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,10 +413,10 @@ const Artifacts = ({
const tableHeaders = useMemo(() => tableContent[0]?.content ?? [], [tableContent])

useEffect(() => {
if (params.id && pageData.details.menu.length > 0) {
if (params.id && !isEmpty(selectedArtifact) && pageData.details.menu.length > 0) {
isDetailsTabExists(params.tab, pageData.details.menu, navigate, location)
}
}, [navigate, location, pageData.details.menu, params.tab, params.id])
}, [navigate, location, pageData.details.menu, params.tab, params.id, selectedArtifact])

useEffect(() => {
if (isEmpty(selectedArtifact)) {
Expand Down
19 changes: 16 additions & 3 deletions src/components/FeatureStore/FeatureSets/FeatureSets.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ such restriction.
import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react'
import { useLocation, useNavigate, useParams, useSearchParams } from 'react-router-dom'
import { useSelector, useDispatch } from 'react-redux'
import { cloneDeep } from 'lodash'
import { cloneDeep, isEmpty } from 'lodash'

import FeatureSetsView from './FeatureSetsView'
import { FeatureStoreContext } from '../FeatureStore'
Expand Down Expand Up @@ -391,10 +391,23 @@ const FeatureSets = () => {
}, [featureStore.featureSets.allData, navigate, params.name, params.projectName, params.tag])

useEffect(() => {
if (params.name && params.tag && pageData.details.menu.length > 0) {
if (
params.name &&
params.tag &&
!isEmpty(selectedFeatureSet) &&
pageData.details.menu.length > 0
) {
isDetailsTabExists(params.tab, pageData.details.menu, navigate, location)
}
}, [navigate, location, pageData.details.menu, params.name, params.tag, params.tab])
}, [
navigate,
location,
pageData.details.menu,
params.name,
params.tag,
params.tab,
selectedFeatureSet
])

useEffect(() => {
checkTabIsValid(navigate, params, selectedFeatureSet, FEATURE_SETS_TAB)
Expand Down
17 changes: 15 additions & 2 deletions src/components/FeatureStore/FeatureVectors/FeatureVectors.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,10 +458,23 @@ const FeatureVectors = () => {
}, [featureStore.featureVectors?.allData, navigate, params.name, params.projectName, params.tag])

useEffect(() => {
if (params.name && params.tag && pageData.details.menu.length > 0) {
if (
params.name &&
params.tag &&
!isEmpty(selectedFeatureVector) &&
pageData.details.menu.length > 0
) {
isDetailsTabExists(params.tab, pageData.details.menu, navigate, location)
}
}, [navigate, location, pageData.details.menu, params.name, params.tag, params.tab])
}, [
navigate,
location,
pageData.details.menu,
params.name,
params.tag,
params.tab,
selectedFeatureVector
])

useEffect(() => {
checkTabIsValid(navigate, params, setSelectedFeatureVector, FEATURE_VECTORS_TAB)
Expand Down
4 changes: 2 additions & 2 deletions src/components/FunctionsPage/Functions.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,10 +503,10 @@ const Functions = ({ isAllVersions = false }) => {
}, [params.projectName])

useEffect(() => {
if (params.id && pageData.details.menu.length > 0) {
if (params.id && !isEmpty(selectedFunction) && pageData.details.menu.length > 0) {
isDetailsTabExists(params.tab, pageData.details.menu, navigate, location)
}
}, [navigate, pageData.details.menu, location, params.id, params.tab])
}, [navigate, pageData.details.menu, location, params.id, params.tab, selectedFunction])

useEffect(() => {
dispatch(setFilters({ groupBy: GROUP_BY_NONE }))
Expand Down
16 changes: 14 additions & 2 deletions src/components/FunctionsPageOld/FunctionsOld.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,10 +537,22 @@ const Functions = () => {
}, [params.projectName])

useEffect(() => {
if ((params.funcName || params.hash) && pageData.details.menu.length > 0) {
if (
(params.funcName || params.hash) &&
!isEmpty(selectedFunction) &&
pageData.details.menu.length > 0
) {
isDetailsTabExists(params.tab, pageData.details.menu, navigate, location)
}
}, [navigate, pageData.details.menu, location, params.hash, params.funcName, params.tab])
}, [
navigate,
pageData.details.menu,
location,
params.hash,
params.funcName,
params.tab,
selectedFunction
])

useEffect(() => {
checkForSelectedFunction(
Expand Down
18 changes: 16 additions & 2 deletions src/components/ModelsPage/ModelEndpoints/ModelEndpointsTable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import React, { useState, useRef, useCallback, useEffect, useMemo } from 'react'
import { useDispatch, useSelector } from 'react-redux'
import { useLocation, useNavigate, useParams } from 'react-router-dom'
import PropTypes from 'prop-types'
import { isEmpty } from 'lodash'

import ActionBar from '../../ActionBar/ActionBar'
import ArtifactsTableRow from '../../../elements/ArtifactsTableRow/ArtifactsTableRow'
Expand Down Expand Up @@ -205,10 +206,23 @@ const ModelEndpointsTable = React.forwardRef(
])

useEffect(() => {
if (params.name && params.tag && pageData.details.menu.length > 0) {
if (
params.name &&
params.tag &&
!isEmpty(selectedModelEndpoint) &&
pageData.details.menu.length > 0
) {
isDetailsTabExists(params.tab, pageData.details.menu, navigate, location)
}
}, [navigate, location, pageData.details.menu, params.name, params.tag, params.tab])
}, [
navigate,
location,
pageData.details.menu,
params.name,
params.tag,
params.tab,
selectedModelEndpoint
])

const tableContent = useMemo(() => {
return modelEndpoints.map(contentItem =>
Expand Down
4 changes: 2 additions & 2 deletions src/elements/JobsTable/JobsTable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,10 +218,10 @@ const JobsTable = React.forwardRef(
)

useEffect(() => {
if (params.jobId && pageData.details.menu.length > 0) {
if (params.jobId && !isEmpty(selectedJob) && pageData.details.menu.length > 0) {
isDetailsTabExists(params.tab, pageData.details.menu, navigate, location)
}
}, [navigate, pageData.details.menu, location, params.jobId, params.tab])
}, [navigate, pageData.details.menu, location, params.jobId, params.tab, selectedJob])

const handleConfirmAbortJob = useCallback(
job => {
Expand Down
16 changes: 14 additions & 2 deletions src/elements/WorkflowsTable/WorkflowsTable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,10 +671,22 @@ const WorkflowsTable = React.forwardRef(
])

useEffect(() => {
if ((params.jobId || params.functionHash) && pageData.details.menu.length > 0) {
if (
(params.jobId || params.functionHash) &&
!isEmpty(selectedJob) &&
pageData.details.menu.length > 0
) {
isDetailsTabExists(params.tab, pageData.details.menu, navigate, location)
}
}, [navigate, pageData.details.menu, location, params.jobId, params.functionHash, params.tab])
}, [
navigate,
pageData.details.menu,
location,
params.jobId,
params.functionHash,
params.tab,
selectedJob
])

useEffect(() => {
const workflow = { ...workflowsStore.activeWorkflow?.data }
Expand Down