fix: ignore diffusers GHSA-98h9-4798-4q5v in pip-audit#24
Merged
Conversation
Same upgrade blocker as the already-ignored GHSA-j7w6-vpvq-j3gm — both are fixed in diffusers 0.38.0, which requires safetensors>=0.8.0rc0 pre-release. Drop both ignores together when the safetensors cap lifts. Signed-off-by: Zhengyuan Su <su.zhengyuan@u.nus.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Silence pip-audit on
GHSA-98h9-4798-4q5v(CVE-2026-44513, HIGH, CVSS 8.8) indiffusers==0.36.0. Same upgrade blocker as the already-ignoredGHSA-j7w6-vpvq-j3gm— both are fixed in diffusers 0.38.0, which requiressafetensors>=0.8.0rc0pre-release that uv lock won't pick up without an explicit opt-in.Changes
.github/workflows/security.yml— add--ignore-vuln GHSA-98h9-4798-4q5vto both pip-audit blocks (worker CPU and worker GPU delta).docs/CODE_STYLE.md— add a row in the ignored-CVE table referencing the same blocker as the existing diffusers row.Design
The advisory is a
trust_remote_code=Falsebypass inDiffusionPipeline.from_pretrainedviacustom_pipeline=(cross-repo or local-snapshot variants) or local snapshots whosemodel_index.jsonreferences custom-component.pyfiles. TheDiffusersExecutorcallsAutoPipelineForText2Image.from_pretrained(ident, **load_kwargs)with a Hub identifier (no local path), nocustom_pipeline=argument, andtrust_remote_code=Trueonly when the workflow explicitly opts in viaspec.model_trust_remote_code. The advisory variants 1 and 2 are unreachable; variant 3 (HF cache snapshot with custom components) is theoretically reachable but bounded by the workflow author's existing trust scope (they can already setmodel_trust_remote_code=True).Bumping to 0.38.0 is the only real fix per the advisory, but it pulls in a
safetensorspre-release. Track the blocker on theGHSA-j7w6-vpvq-j3gmrow and drop both ignores together when the cap lifts.Test Plan
CI.
Test Result
CI passes.
Pre-submission Checklist
pre-commit run --all-filesand fixed any issues.uv run pytest tests/passes locally.uv sync --all-extras --frozen).[BREAKING]and described migration steps above.