Add comprehensive codebase analysis and developer documentation#10
Merged
Merged
Conversation
Analyze PortfolioBench architecture: freqtrade wrapper with 4 exchange.py hacks for multi-asset support, 6 trading/portfolio strategies (ONS, MinVar, InvVol, BestSingleAsset, EmaCross, MacdAdx), pluggable IAlpha interface, standalone portfolio pipeline, and 119 instruments across crypto/stocks/indices. https://claude.ai/code/session_01XWVBdJ1TjJfw3QihQngxuB
tjluyao
added a commit
that referenced
this pull request
Mar 13, 2026
…debase-VDWfl - Add comprehensive codebase analysis and developer guide
tjluyao
added a commit
that referenced
this pull request
Mar 13, 2026
…debase-VDWfl Add comprehensive codebase analysis and developer documentation
ZhuRong818
added a commit
to ZhuRong818/PortfolioBench
that referenced
this pull request
May 14, 2026
The workflow subcommand (mlsys-io#10) introduced a positional argument that crashed the CLI argument parser on every command. This was fixed upstream in mlsys-io/freqtrade#11. Update the submodule pointer from ab093ff to 2607696. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds two comprehensive documentation files to help developers understand the PortfolioBench architecture, design patterns, and usage patterns.
Changes Made
ANALYSIS.md (475 lines)
A detailed technical analysis document covering:
exchange/exchange.pythat enable multi-asset support (synthetic market injection, fee fallback, leverage tier fallback)IAlphainterface andEmaAlphaimplementation for pluggable indicator computationEmaCrossStrategyandMacdAdxStrategyimplementationsCLAUDE.md (40 lines)
A concise developer quick-start guide covering:
exchange.pyhacks that must be preserved during freqtrade updatesNotable Details
https://claude.ai/code/session_01XWVBdJ1TjJfw3QihQngxuB