Skip to content

Remove dependency on libavdevice#1239

Closed
dimula73 wants to merge 1 commit into
mltframework:masterfrom
dimula73:kazakov/remove-avdevice-dep
Closed

Remove dependency on libavdevice#1239
dimula73 wants to merge 1 commit into
mltframework:masterfrom
dimula73:kazakov/remove-avdevice-dep

Conversation

@dimula73
Copy link
Copy Markdown
Contributor

@dimula73 dimula73 commented May 8, 2026

It seems like the actual usage of avdevice has been removed long ago and replaced with SDL.

It seems like the actual usage of avdevice has been
removed long ago and replaced with SDL.
@dimula73
Copy link
Copy Markdown
Contributor Author

dimula73 commented May 8, 2026

I'm not very sure my understanding is right, but I haven't found any usage of avdevice by MLT internally. I have a feeling that this dependency is a legacy artifact from ~2011.

In Krita we have been building ffmpeg without avdevice and MLT worked fine until the recent dependency policy change in 604972b

@ddennedy
Copy link
Copy Markdown
Member

ddennedy commented May 8, 2026

MLT can use device input through the avformat producer.

Copy link
Copy Markdown
Member

@ddennedy ddennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you really want something like this, change the build to make it optional instead of removing it. For example, Shotcut supports these input devices through MLT: alsa, pulseaudio, v4l2, dshow, avfoundation.

@dimula73
Copy link
Copy Markdown
Contributor Author

dimula73 commented May 9, 2026

Shotcut supports these input devices through MLT: alsa, pulseaudio, v4l2, dshow, avfoundation.

Isn't it a responsibility of the caller to create (and, hence, initialize) avdevice then? I haven't found any other avdevice-related code in MLT.

If you really want something like this, change the build to make it optional instead

I could do that. Is it okay that it would technically revert a part of 604972b ?

@ddennedy
Copy link
Copy Markdown
Member

ddennedy commented May 9, 2026

Isn't it a responsibility of the caller to create (and, hence, initialize) avdevice then?

no

Is it okay that it would technically revert a part

Yes, that is basically what I said or maintain this patch.

@dimula73
Copy link
Copy Markdown
Contributor Author

Okay, I'll modify the patch, thanks!

@dimula73
Copy link
Copy Markdown
Contributor Author

This MR can now be closed in favor of the new one, that makes avdevice optional: #1246

@dimula73 dimula73 closed this May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants