Remove dependency on libavdevice#1239
Conversation
It seems like the actual usage of avdevice has been removed long ago and replaced with SDL.
|
I'm not very sure my understanding is right, but I haven't found any usage of avdevice by MLT internally. I have a feeling that this dependency is a legacy artifact from ~2011. In Krita we have been building |
|
MLT can use device input through the avformat producer. |
ddennedy
left a comment
There was a problem hiding this comment.
If you really want something like this, change the build to make it optional instead of removing it. For example, Shotcut supports these input devices through MLT: alsa, pulseaudio, v4l2, dshow, avfoundation.
Isn't it a responsibility of the caller to create (and, hence, initialize) avdevice then? I haven't found any other avdevice-related code in MLT.
I could do that. Is it okay that it would technically revert a part of 604972b ? |
no
Yes, that is basically what I said or maintain this patch. |
|
Okay, I'll modify the patch, thanks! |
|
This MR can now be closed in favor of the new one, that makes avdevice optional: #1246 |
It seems like the actual usage of avdevice has been removed long ago and replaced with SDL.