Add new Spot Remover filter.#373
Merged
ddennedy merged 1 commit intomltframework:masterfrom Oct 15, 2018
Merged
Conversation
ddennedy
reviewed
Oct 15, 2018
| uint8_t* xValueL = chan + ( y * rowSize ) + ( ( (int)rect.x - 1 ) * step ); | ||
| uint8_t* xValueR = xValueL + ( (int)rect.w * step ); | ||
| uint8_t* p = chan + ( y * rowSize ) + ( (int)rect.x * step ); | ||
| float yRatio = 1.0 - ( ( y - rect.y ) / rect.h ); |
Member
There was a problem hiding this comment.
This is a nitpick, but I would have chosen double here especially since the literal value 1.0 is double. Add 'f' after a literal numeric to make it float.
Member
Author
There was a problem hiding this comment.
Good point. Fixed it here 8dd6f12 along with another typo:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This filter implements a similar capability as the avfilter.delogo filter. However, I did not port the code from delogo because I didn't really understand it. So the exact interpolation algorithm is different.
Unlike delogo, this filter supports keyframes. Also, it does not crash if the rectangle is outside of the active video.