Skip to content

Minor default prompt fixes#55

Merged
edgararuiz merged 2 commits intomlverse:mainfrom
mattwarkentin:main
Jun 4, 2025
Merged

Minor default prompt fixes#55
edgararuiz merged 2 commits intomlverse:mainfrom
mattwarkentin:main

Conversation

@mattwarkentin
Copy link
Copy Markdown
Contributor

Cool package, @edgararuiz! A few minor suggestions for the default prompts.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.60%. Comparing base (05aabe0) to head (d6c42f1).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   98.60%   98.60%           
=======================================
  Files          27       27           
  Lines        1000     1000           
=======================================
  Hits          986      986           
  Misses         14       14           
Flag Coverage Δ
unittests 96.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edgararuiz edgararuiz merged commit b96251f into mlverse:main Jun 4, 2025
13 checks passed
@edgararuiz
Copy link
Copy Markdown
Collaborator

Thank you @mattwarkentin !!

@mattwarkentin
Copy link
Copy Markdown
Contributor Author

Sorry, I should've checked the tests when making this change!

@edgararuiz
Copy link
Copy Markdown
Collaborator

No problem at all, finalizing the PR is the easy part for me. The harder part is to catch those little spelling/grammar errors where the IDE does not warn me 😄 thanks again for you help with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants