Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 94.10% 94.22% +0.12%
==========================================
Files 23 23
Lines 1341 1265 -76
==========================================
- Hits 1262 1192 -70
+ Misses 79 73 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Change maintainer to Tomasz Kalinowski (matching torch)
- Bump version to 0.0.5
- Condition summary_audio example on wav availability
- Add skip_if_not_installed("wav") to audio/read tests
- Register internal as_tensor_proto S3 methods (roxygen2 7.3.3)
- Add .claude to .Rbuildignore
Rely on reticulate's automatic Python dependency management via the tensorflow R package instead of manually installing.
Add py_require("tbparse") in test helper so reticulate handles
installation automatically. Remove manual py_install steps from
check and test-coverage workflows.
Resolve tensorboard binary from reticulate's Python bin directory instead of relying on PATH or tensorflow::tensorboard() which fails with newer tensorboard versions.
Provides a working tensorboard launcher that finds the binary from reticulate's Python environment. Replaces tensorflow::tensorboard() calls in articles which broke with newer tensorboard versions.
TF 2.21+ no longer installs the tensorboard CLI binary, so pin to <=2.18 where the binary is still available.
Revert the custom tensorboard() function. Instead, pin tensorflow<=2.18 and add setuptools to py_require so that tensorflow::tensorboard() works (newer TF drops the CLI binary, and tensorboard needs pkg_resources from setuptools).
Revert articles to use tensorflow::tensorboard() as-is. Restore py_install step in pkgdown workflow with tensorflow==2.14 and numpy<2 to ensure a proper pip environment where the tensorboard CLI works correctly.
Strip [[deprecated]] and [[nodiscard]] attributes from generated .pb.h/.pb.cc files in configure. Also fix nodiscard warning in reader.cpp by casting ParseFromString return value to void.
Loading tensorflow during R CMD check creates ~/.keras/keras.json which violates CRAN policy. Tests only need tbparse.
… install
- Add skip for tensorflow in test-image.R line 19
- Restore py_install('tbparse') in check and test-coverage workflows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
summary_audioexample to skip whenwavis not installed (@examplesIf)skip_if_not_installed("wav")to 3 tests that require itas_tensor_protoS3 methods to fix roxygen2 7.3.3 warnings.claudeto.RbuildignoreTest plan
devtools::check()passes with 0 errors and 0 test failuresdevtools::submit_cran()