Merged
Conversation
…o bugfix/fr_translation # Conflicts: # DESCRIPTION
c535435 to
efbf2f1
Compare
Member
|
@cregouby I rebased the PR. Some test cases are failing, and they seem related to this PR. |
Collaborator
Author
|
Oh ! Sorry for that. |
Member
|
No worries, let me know if you want me to take a look too! |
Member
|
I also just added you as a collaborator so you don't need to wait for me to approve and run your PR's. |
Collaborator
Author
|
Thanks, I feel honored ! |
…o bugfix/fr_translation # Conflicts: # NEWS.md # R/conditions.R # inst/po/fr/LC_MESSAGES/R-torch.mo
This reverts commit d27c4f9.
…o bugfix/fr_translation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some exchange with Philippe Grosjean during the French Rencontre R 2024,
I finally got the correct way to wrap R-level messages so that they get translated.
Note
Cpp-level translation is
"messages"into_("message")but gettext does not get the one inRcpp::stop(). I'll make it explicit in a issue.