Making Flickr consistent with the other dataset loaders #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cregouby
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
flickr8k_caption_dataset()andflickr30k_caption_dataset()were newly committed, they had some inconsistencies with the other datasets that we have made consistent. Hence, this PR adds support.Since 'flickr30k_caption_dataset()
inheritsflickr8k_caption_dataset()` (Closes **maximize inheritance** of existing dataset functions #177 )I think @koshtiakanksha had already (Resolved generalize detailed user messaging for long step operations (following the ones in caltech ) #179 ) , (Resolved **maximize reusage** of parameter documentation (through copy tags with @inheritParams, @inheritSection, or @inherit.) #182 ) and (Resolved **reuse** and or generalize **user messages** through the use of **consistent variable name** (like download and processing info and warnings) #183 )
Thus, we have together (Resolved #165 )