fix(migrate): reject scaffold names that produce a Go _test.go file#28
Merged
Conversation
A migration named so its file ends in _test.go (e.g. "smoke_test" → <id>_smoke_test.go) is silently excluded from the package build by Go's test-file rule, leaving an undefined reference in the All slice. Scaffold now rejects such names before writing anything, with a message telling the author to rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A migration whose generated file would end in
_test.go(e.g. naming itsmoke_test→<id>_smoke_test.go) is silently excluded from the package build by Go's test-file rule, so theAllslice references an undefined var and the package won't compile.Scaffoldnow validates the filename before writing and returns an actionable error. Follow-up to #26/#27.