OneTime Code Input #128
Merged
OneTime Code Input #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@eminsr thank you, looks awesome 👍 I'm gonna give it a try during the weekend. |
Using PlatformColor for borderColor throws and error so I hardcoded the colors for android
mmazzarolo
approved these changes
Oct 23, 2021
Owner
mmazzarolo
left a comment
mmazzarolo
left a comment
There was a problem hiding this comment.
Tested it, looks good! 👍 There are a couple of things I think we can improve later, but this is a solid starting point. Thanks for updating docs, etc. too!
github-actions bot
pushed a commit
that referenced
this pull request
Oct 23, 2021
# [9.2.0](v9.1.2...v9.2.0) (2021-10-23) ### Features * Add `CodeInput` component ([#128](#128)) ([961f9a0](961f9a0))
|
🎉 This PR is included in version 9.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
With this PR
react-native-dialoggains one-time code input with changeable length.I needed a one-time code input implementation of native dialogs so implemented the functionality to the lib.
I don't know if this is a future that everyone would use since you can achieve the same functionality without altering the lib.