Make no-progress detection failure-sensitive#384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
failure_fingerprint(stdout, stderr, exit_code)that extracts and normalizes the most informative failure line (stripping ANSI, paths, temp paths, timestamps, UUIDs, addresses, line numbers) and falls back to a compact hashed tail. (seevillani_code/execution_context.py)CommandRecord.failure_fingerprintandValidationEvidence.failure_fingerprint, and compute it from commandstdout/stderrwhen building command records._evidence_repetitionsand_progress_epoch) so that intervening workspace mutations or new diagnostic evidence reset repetition pressure.Write/Patch), so identical failures after meaningful changes are treated as progress.Testing
pytest -q tests/test_execution_context_isolation.py(targeted tests exercising the new logic) and all tests in that file passed.ruff checkon the modified files and it passed.pytest -q; the changes did not affect the targeted execution-context tests, but the full run reported 7 unrelated failures in hardening/interactive/mission/planning/TUI contract tests (these failures predate or are outside the scope of the execution-context change).Codex Task