Use bytemuck::Zeroable for zeroable types.#1371
Merged
wks merged 1 commit intommtk:masterfrom Aug 15, 2025
Merged
Conversation
Our utility function `zeroed_alloc::new_zeroed_vec<T>` now requires the element type `<T>` to implement `bytemuck::Zeroable`, a marker trait which means the type can be safely initialized with all zero bits. `new_zeroed_vec` is no longer `unsafe`. `SpaceDescriptor` now implements `Zeroable` because a zero value represents `SpaceDescriptor::UNINITIALIZED`. `Map32` now uses `new_zeroed_vec` for allocating the `descriptor_map` because when used on 64-bit machines (usually with compressed pointers), the number of chunks can still be large.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our utility function
zeroed_alloc::new_zeroed_vec<T>now requires the element type<T>to implementbytemuck::Zeroable, a marker trait which means the type can be safely initialized with all zero bits.new_zeroed_vecis no longerunsafe.SpaceDescriptornow implementsZeroablebecause a zero value representsSpaceDescriptor::UNINITIALIZED.Map32now usesnew_zeroed_vecfor allocating thedescriptor_mapbecause when used on 64-bit machines (usually with compressed pointers), the number of chunks can still be large.